linux-ext4 - Re: [PATCH] debugfs: with ls -l, include space between size and date

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2017 13:06:50 -0700
From:   Andreas Dilger <adilger@...ger.ca>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>,
        Theodore Ts'o <tytso@....edu>,
        Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH] debugfs: with ls -l, include space between size and date

On Feb 12, 2017, at 5:01 PM, Eric Biggers <ebiggers3@...il.com> wrote:
> 
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Before:
>     11   40700 (2)      0      0   1228812-Feb-2017 12:51 lost+found
> 
> After:
>     11   40700 (2)      0      0   12288 12-Feb-2017 12:51 lost+found
> 
> Fixes: 68a1de3df340 ("debugfs: pretty print encrypted filenames in the ls command")
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> debugfs/ls.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/debugfs/ls.c b/debugfs/ls.c
> index 057e3f6f..c990a93d 100644
> --- a/debugfs/ls.c
> +++ b/debugfs/ls.c
> @@ -156,8 +156,7 @@ static int list_dir_proc(ext2_ino_t dir EXT2FS_ATTR((unused)),
> 			fprintf(ls->f, "%5d", inode.i_size);
> 		else
> 			fprintf(ls->f, "%5llu", EXT2_I_SIZE(&inode));
> -		fputs(datestr, ls->f);
> -		fputc(' ', ls->f);
> +		fprintf(ls->f, " %s ", datestr);
> 		print_filename(ls->f, dirent, options);
> 		fputc('\n', ls->f);
> 	} else {
> --
> 2.11.1
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)