linux-ext4 - RE: Re: [PATCH] ext4: hand over jobs handling discard commands on commit complete phase to kworkers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 May 2017 00:45:29 +0000
From:   Daeho Jeong <daeho.jeong@...sung.com>
To:     Christoph Hellwig <hch@...radead.org>,
        Daeho Jeong <daeho.jeong@...sung.com>
Cc:     "jack@...e.com" <jack@...e.com>, "tytso@....edu" <tytso@....edu>,
        "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>
Subject: RE: Re: [PATCH] ext4: hand over jobs handling discard commands on
 commit complete phase to kworkers

>> Now, when we mount ext4 filesystem with '-o discard' option, we have to
>> issue all the discard commands for the blocks to be deallocated and
>> wait for the completion of the commands on the commit complete phase.
 
> No, you don't.  You can execute them asynchronously, similar to what
> XFS already does.

Thank you, I will check XFS codes issuing discard commands asynchronously.
But, even if the discard commands can be handled in parallel by doing this,
we still need to wait for all the discard requests completion on the journaling
commit phase. I want to modify this part, too.