linux-ext4 - Re: [PATCH 18/32] ext4: retry storing value in external inode with xattr block too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Jun 2017 22:22:05 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Andreas Dilger <adilger@...ger.ca>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/32] ext4: retry storing value in external inode with
 xattr block too

On Wed, Jun 21, 2017 at 02:21:28PM -0700, Tahsin Erdogan wrote:
> When value size is <= EXT4_XATTR_MIN_LARGE_EA_SIZE(), and it
> doesn't fit in either inline or xattr block, a second try is made to
> store it in an external inode while storing the entry itself in inline
> area. There should also be an attempt to store the entry in xattr block.
> 
> This patch adds a retry loop to do that. It also makes the caller the
> sole decider on whether to store a value in an external inode.
> 
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>

Thanks, added to the ext4 patch queue.

						- Ted