lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 23 Jun 2017 00:33:02 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Khazhismel Kumykov <khazhy@...gle.com>, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry

On Jun 22, 2017, at 22:43, Theodore Ts'o <tytso@....edu> wrote:
> 
>> On Thu, Jun 22, 2017 at 04:23:07PM -0700, Khazhismel Kumykov wrote:
>> Previously, a read error would be ignored and we would eventually return
>> NULL from ext4_find_entry, which signals "no such file or directory". We
>> should be returning EIO.
>> 
>> Signed-off-by: Khazhismel Kumykov <khazhy@...gle.com>
> 
> Thanks, applied.

I don't necessarily agree that this is an improvement. 

If the requested entry is not in the bad block, this will return an error even if the file name could be found in another block. It would be better to save the error until the end and only return -EIO if the entry cannot be found. 

Cheers, Andreas

Powered by blists - more mailing lists