lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Aug 2017 22:16:45 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: sandeen@...hat.com Cc: SF Markus Elfring <elfring@...rs.sourceforge.net>, linux-ext4@...r.kernel.org, Andreas Dilger <adilger.kernel@...ger.ca>, "Theodore Ts'o" <tytso@....edu>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect() On Sat, Aug 19, 2017 at 12:08:29PM -0500, Eric Sandeen wrote: > On 8/19/17 6:47 AM, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@...rs.sourceforge.net> > > Date: Sat, 19 Aug 2017 13:04:50 +0200 > > > > Omit an extra message for a memory allocation failure in this function. > > I might be dense, but what makes this message "extra?" > > (I suppose kmalloc squawks too if it fails, but is Coccinelle > now warning about explicit memory allocation failure warnings?) > Yeah... Checkpatch complains that the kmalloc squawks is enough. "WARNING: Possible unnecessary 'out of memory' message". This allocation is small so it's guaranteed to succeed in current kernels. regards, dan carpenter
Powered by blists - more mailing lists