lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Aug 2017 09:26:54 +0200 From: Jan Kara <jack@...e.cz> To: Christoph Hellwig <hch@...radead.org> Cc: Jan Kara <jack@...e.cz>, linux-fsdevel@...r.kernel.org, Boaz Harrosh <boazh@...app.com>, linux-nvdimm@...ts.01.org, linux-xfs@...r.kernel.org, Andy Lutomirski <luto@...nel.org>, linux-ext4@...r.kernel.org Subject: Re: [PATCH 09/13] dax: Allow dax_iomap_fault() to return pfn On Wed 23-08-17 11:34:00, Christoph Hellwig wrote: > > @@ -1416,6 +1416,7 @@ static int dax_iomap_pmd_fault(struct vm_fault *vmf, > > * @vmf: The description of the fault > > * @pe_size: Size of the page to fault in > > * @ops: Iomap ops passed from the file system > > + * @pfnp: PFN to insert for synchronous faults if fsync is required > > * > > * When a page fault occurs, filesystems may call this helper in > > * their fault handler for DAX files. dax_iomap_fault() assumes the caller > > @@ -1423,13 +1424,13 @@ static int dax_iomap_pmd_fault(struct vm_fault *vmf, > > * successfully. > > */ > > int dax_iomap_fault(struct vm_fault *vmf, enum page_entry_size pe_size, > > - const struct iomap_ops *ops) > > + const struct iomap_ops *ops, pfn_t *pfnp) > > Please keep the iomap_ops argument the last one for the exported > function (and probably all others for consistency). Hum, I wanted the output argument to be the last one. But I don't care much. Swapped. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@....de> Thanks! Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists