lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Aug 2017 11:18:36 -0400 From: Theodore Ts'o <tytso@....edu> To: Arnd Bergmann <arnd@...db.de> Cc: Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext4: avoid Y2038 overflow in recently_deleted() On Wed, Aug 30, 2017 at 11:03:08PM +0200, Arnd Bergmann wrote: > On Fri, Aug 25, 2017 at 8:48 PM, Andreas Dilger <adilger@...ger.ca> wrote: > > Avoid a 32-bit time overflow in recently_deleted() since i_dtime > > (inode deletion time) is stored only as a 32-bit value on disk. > > Since i_dtime isn't used for much beyond a boolean value in e2fsck > > and is otherwise only used in this function in the kernel, there is > > no benefit to use more space in the inode for this field on disk. > > > > Instead, compare only the relative deletion time with the low > > 32 bits of the time using the newly-added time_before32() helper, > > which is similar to time_before() and time_after() for jiffies. > > > > Increase RECENTCY_DIRTY to 300s based on Ted's comments about > > usage experience at Google. > > > > Signed-off-by: Andreas Dilger <adilger@...ger.ca> > > Change-Id: I7402e1b3d49ea326f872ec8324933f42b502b9be > > Reviewed-by: Arnd Bergmann <arnd@...db.de> Thanks, applied. - Ted
Powered by blists - more mailing lists