linux-ext4 - Re: [PATCH 2/3] Fix typos in code comments and developer docs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 15 Oct 2017 02:38:21 +0200
From:   Sebastian Rasmussen <sebras@...il.com>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/3] Fix typos in code comments and developer docs.

Hi!

> Did you use a tool to extract comments and then run this through a spell
> checker, or actually read all of the comments manually?  Some of the
> errors are very hard to notice, even when already knowing the line has
> a correction.

I simply ran aspell over the unchanged source code (aspell reads
C code better than you'd expect!), incrementally adding correctly
spelled unknown words to a private dictionary and fixing the typos
that aspell found. Finally I categorized the typos since I didn't know
if you'd want typos that are invisible to end users fixed.

>> +             // 3-d letter should be a digit.
> This should probably be "3rd letter"?

I was wondering what that 3D letter was all about.
3rd makes better sense. I have attached a new version
of the patch to this mail.

> Since the "tdb" code was copied from another project, you might
> consider to also submit these corrections to the original project.

I have started doing the same to the code over at
https://git.samba.org/samba.git/?p=ctdb.git

Hopefully they will be equally happy about getting a patch. :)

 / Sebastian

View attachment "0002-Fix-typos-in-code-comments-and-developer-docs.patch" of type "text/x-patch" (58118 bytes)