lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 4 Jan 2018 16:40:18 +0100
From:   Jan Kara <jack@...e.cz>
To:     Colin King <colin.king@...onical.com>
Cc:     Theodore Ts'o <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: fix incorrect indentation of if statement

On Wed 29-11-17 14:20:59, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The indentation is incorrect and spaces need replacing with a tab
> on the if statement.
> 
> Cleans up smatch warning:
> fs/ext4/namei.c:3220 ext4_link() warn: inconsistent indenting
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

This seems to fall through cracks. The patch looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza


> ---
>  fs/ext4/namei.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 798b3ac680db..d3fabc553c65 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -3217,8 +3217,8 @@ static int ext4_link(struct dentry *old_dentry,
>  	if (err)
>  		return err;
>  
> -       if ((ext4_test_inode_flag(dir, EXT4_INODE_PROJINHERIT)) &&
> -	   (!projid_eq(EXT4_I(dir)->i_projid,
> +	if ((ext4_test_inode_flag(dir, EXT4_INODE_PROJINHERIT)) &&
> +	    (!projid_eq(EXT4_I(dir)->i_projid,
>  		       EXT4_I(old_dentry->d_inode)->i_projid)))
>  		return -EXDEV;
>  
> -- 
> 2.14.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux - Powered by OpenVZ