linux-ext4 - Re: [PATCH] ext4: no need flush workqueue before destroying it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Jan 2018 08:16:47 +0800
From:   piaojun <piaojun@...wei.com>
To:     Jan Kara <jack@...e.cz>
CC:     <adilger.kernel@...ger.ca>, <arnd@...db.de>,
        <linux-ext4@...r.kernel.org>, Ted Tso <tytso@....edu>
Subject: Re: [PATCH] ext4: no need flush workqueue before destroying it

Hi Jan,

Thanks for reviewing, and I will resend this patch again.

thanks,
Jun

On 2018/1/9 23:07, Jan Kara wrote:
> On Tue 09-01-18 20:37:54, piaojun wrote:
>> destroy_workqueue() will do flushing work for us.
>>
>> Signed-off-by: Jun Piao <piaojun@...wei.com>
> 
> Looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> 
> Adding Ted to CC as a maintainer...
> 
> 								Honza
> 
>> ---
>>  fs/ext4/super.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
>> index 0556cd0..2f46b0b 100644
>> --- a/fs/ext4/super.c
>> +++ b/fs/ext4/super.c
>> @@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
>>  	ext4_unregister_li_request(sb);
>>  	ext4_quota_off_umount(sb);
>>
>> -	flush_workqueue(sbi->rsv_conversion_wq);
>>  	destroy_workqueue(sbi->rsv_conversion_wq);
>>
>>  	if (sbi->s_journal) {
>> --