linux-ext4 - Re: [PATCH 09/10] e2fsck: require that fast symlinks don't have EXT4_EXTENTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Mar 2018 17:50:04 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     linux-ext4@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH 09/10] e2fsck: require that fast symlinks don't have
 EXT4_EXTENTS_FL

On Fri, Mar 02, 2018 at 04:59:22PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> It doesn't make sense for EXT4_EXTENTS_FL to be set on a fast symlink.
> The kernel doesn't set it, and it ignores it if set.  Meanwhile, e2fsck
> is stricter: it will try to validate the extent tree, which will almost
> certainly fail (assuming the symlink is, in fact, a fast symlink).
> 
> Make this behavior more explicit by rejecting EXT4_EXTENTS_FL for fast
> symlinks, rather than going ahead and trying to validate an extent tree.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Thanks, applied.

					- Ted