[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 3 Mar 2018 17:49:25 -0500
From: Theodore Ts'o <tytso@....edu>
To: Eric Biggers <ebiggers3@...il.com>
Cc: linux-ext4@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH 08/10] e2fsck: validate the targets of extent-based
symlinks
On Fri, Mar 02, 2018 at 04:59:21PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
>
> e2fsck is validating the target (requiring that it be NUL-terminated at
> i_size, or something a bit different for encrypted symlinks) of slow
> symlinks that use a traditional block list but not ones that use an
> extent tree. As far as I can tell this is simply a bug: there's no
> reason for the representation of the block list to affect how the
> symlink target is validated. And either way the kernel won't create
> symlinks with embedded NULs and will always add a terminating NUL.
>
> Thus, make e2fsck_pass1_check_symlink() start validating the targets of
> extent-based symlinks.
>
> Fixes: 7cadc57780f3 ("e2fsck: Support long symlinks which use extents")
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
Thanks, applied.
- Ted
Powered by blists - more mailing lists