linux-ext4 - Re: [PATCH 1/7] ext4: add tracepoints for shutdown and file system errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Mar 2018 17:50:18 +0100
From:   Jan Kara <jack@...e.cz>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 1/7] ext4: add tracepoints for shutdown and file system
 errors

On Mon 19-02-18 21:30:32, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@....edu>
> ---
>  fs/ext4/ioctl.c             |  1 +
>  fs/ext4/super.c             |  4 ++++
>  include/trace/events/ext4.h | 43 +++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 48 insertions(+)
> 
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index 7e99ad02f1ba..4d1b1575f8ac 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -481,6 +481,7 @@ static int ext4_shutdown(struct super_block *sb, unsigned long arg)
>  		return 0;
>  
>  	ext4_msg(sb, KERN_ALERT, "shut down requested (%d)", flags);
> +	trace_ext4_shutdown(sb, flags);
>  
>  	switch (flags) {
>  	case EXT4_GOING_FLAGS_DEFAULT:
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 39bf464c35f1..756f515b762d 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -448,6 +448,7 @@ void __ext4_error(struct super_block *sb, const char *function,
>  	if (unlikely(ext4_forced_shutdown(EXT4_SB(sb))))
>  		return;
>  
> +	trace_ext4_error(sb, function, line);
>  	if (ext4_error_ratelimit(sb)) {
>  		va_start(args, fmt);
>  		vaf.fmt = fmt;

What are the 'error' tracepoints good for? So that you have occurrence of
ext4_error() calls in the same stream of events as other tracepoints?

Otherwise the patch looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR