linux-ext4 - Re: [Patch 1/4] Support for checking and reading block grade information in kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Apr 2018 22:57:10 +0530
From:   Sayan Ghosh <sgdgp.2014@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        niloy ganguly <ganguly.niloy@...il.com>,
        "Bhattacharya, Suparna" <suparna.bhattacharya@....com>,
        Madhumita Mallick <madhu.cse.ju@...il.com>,
        "Bharde, Madhumita" <madhumita.bharde@....com>
Subject: Re: [Patch 1/4] Support for checking and reading block grade
 information in kernel

Hi Randy,

Thank you for looking into the patchset and providing your suggestions
and comments.
We are working on the implementation for the current version of kernel
and will post the code for that soon.

We will definitely keep in mind the style and indentation issues that
you pointed out.

Regards,
Sayan Ghosh
‌On Fri, Apr 6, 2018 at 10:39 PM, Randy Dunlap <rdunlap@...radead.org> wrote:
> On 04/06/2018 04:41 AM, Sayan Ghosh wrote:
>> This introduces the different functions in order to get the grades as
>> the extended attributes while pre-allocating a new file. The grades
>> are stored as extended attributes while the file gets created. The
>> grades can be used by different user space applications as necessary.
>> The functions introduced are read_grade_xattr(), is_file_graded(),
>> read_count_xattr() which aim to read the extended attribute for grade
>> array and also to know whether the file is graded. The detailed
>> descriptions of the functions are provided as comments in the patch.
>> The patch is on top of Linux Kernel 4.7.2.
>
> Well, it's up to Ted if he wants to merge a patch that is based on 4.7.2.
> In general, patches are made to the current mainline or -next tree,
> while 4.7.2 was released on 2016-Aug-20.
>
>>
>> Signed-off-by: Sayan Ghosh <sgdgp.2014@...il.com>
>> ---
>>  fs/ext4/ext4.h    | 15 +++++++++++++++
>>  fs/ext4/extents.c | 35 +++++++++++++++++++++++++++++++++++
>>  2 files changed, 50 insertions(+)
>>
>> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
>> index b84aa1c..b9ec0ca 100755
>> --- a/fs/ext4/ext4.h
>> +++ b/fs/ext4/ext4.h
>> @@ -136,6 +136,18 @@ enum SHIFT_DIRECTION {
>>  /* Use blocks from reserved pool */
>>  #define EXT4_MB_USE_RESERVED        0x2000
>>
>> +/* Structure of a grade - starting block number
>> + * and length of contiguous blocks with same higher
>> + * grade (inclusive of starting block)
>> + * example : if blocks 2,3,4 are higher graded,
>> + * then block_num = 2 and len = 3
>> + * Only high grade information is stored by this struct.
>> + */
>
> Wrong multi-line format style (unless ext4 is like netdev :).
>
> --
> ~Randy

</sgdgp.2014@...il.com></rdunlap@...radead.org>