linux-ext4 - Re: [PATCH] jbd2: remove bunch of empty lines with jbd2 debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 20 May 2018 22:20:53 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Wang Shilong <wangshilong1991@...il.com>
Cc:     linux-ext4@...r.kernel.org, jack@...e.com,
        Wang Shilong <wshilong@....com>
Subject: Re: [PATCH] jbd2: remove bunch of empty lines with jbd2 debug

On Fri, May 18, 2018 at 10:08:07PM +0900, Wang Shilong wrote:
> From: Wang Shilong <wshilong@....com>
> 
> See following dmesg output with jbd2 debug enabled:
> 
> ...(start_this_handle, 313): New handle 00000000c88d6ceb going live.
> 
> ...(start_this_handle, 383): Handle 00000000c88d6ceb given 53 credits (total 53, free 32681)
> 
> ...(do_get_write_access, 838): journal_head 0000000002856fc0, force_copy 0
> 
> ...(jbd2_journal_cancel_revoke, 421): journal_head 0000000002856fc0, cancelling revoke
> 
> We have an extra line with every messages, this is a waste of buffer,
> we can fix it by removing "\n" in the caller or remove it in
> the __jbd2_debug(), i checked every jbd2_debug() passed '\n' explicitly.
> 
> To avoid more lines, let's remove it inside __jbd2_debug().
> 
> Signed-off-by: Wang Shilong <wshilong@....com>

Thanks, applied.

					- Ted