linux-ext4 - [PATCH 07/10] debugfs: Allow read-write opening in catastrophic mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 May 2018 14:51:15 +0200
From:   Jan Kara <jack@...e.cz>
To:     Ted Tso <tytso@....edu>
Cc:     <linux-ext4@...r.kernel.org>, Jan Kara <jack@...e.cz>
Subject: [PATCH 07/10] debugfs: Allow read-write opening in catastrophic mode

Allow filesystem to be open read-write in catastrophic mode so that one
can fixup e.g. superblock breakage. The CHECK_FS_BITMAPS flag to
common_args_process() still guards us from doing operations on bitmaps
which we don't load in this mode.

Signed-off-by: Jan Kara <jack@...e.cz>
---
 debugfs/debugfs.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
index 905c8cdc6733..b1842443aa8e 100644
--- a/debugfs/debugfs.c
+++ b/debugfs/debugfs.c
@@ -159,11 +159,6 @@ static void open_filesystem(char *device, int open_flags, blk64_t superblock,
 		}
 	}
 
-	if (catastrophic && (open_flags & EXT2_FLAG_RW)) {
-		com_err(device, 0,
-			"opening read-only because of catastrophic mode");
-		open_flags &= ~EXT2_FLAG_RW;
-	}
 	if (catastrophic)
 		open_flags |= EXT2_FLAG_SKIP_MMP;
 
-- 
2.13.6