linux-ext4 - Re: [PATCH] iomap: Add inline data support to iomap_readpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 1 Jul 2018 23:43:43 +0200
From:   Andreas Gruenbacher <agruenba@...hat.com>
To:     Christoph Hellwig <hch@....de>
Cc:     cluster-devel <cluster-devel@...hat.com>,
        linux-ext4 <linux-ext4@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH] iomap: Add inline data support to iomap_readpage_actor

On 1 July 2018 at 08:21, Christoph Hellwig <hch@....de> wrote:
> Looks sensible, although I think it could use some more sanity checking
> and a changelog.  Does the version below work for you?

Almost.

> ---
> From e4603b7acde9b77e7a4aad6038c7ac42ca35772d Mon Sep 17 00:00:00 2001
> From: Andreas Gruenbacher <agruenba@...hat.com>
> Date: Fri, 29 Jun 2018 16:44:44 +0200
> Subject: iomap: Add inline data support to iomap_readpage_actor
>
> Just copy the inline data into the page using the existing helper.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@...hat.com>
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  fs/iomap.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/fs/iomap.c b/fs/iomap.c
> index 4d8ff0f5ecc9..966ffad9706a 100644
> --- a/fs/iomap.c
> +++ b/fs/iomap.c
> @@ -155,6 +155,13 @@ iomap_readpage_actor(struct inode *inode, loff_t pos, loff_t length, void *data,
>         bool is_contig = false;
>         sector_t sector;
>
> +       if (iomap->type == IOMAP_INLINE) {
> +               WARN_ON_ONCE(poff);

This is ok.

> +               WARN_ON_ONCE(plen != PAGE_SIZE);

Inline mappings only extend to the end of the file (iomap->offset == 0
&& iomap->length == inode->i_size), so length and plen will be
inode->i_size here. This assertion should just be removed.

> +               iomap_read_inline_data(inode, page, iomap);
> +               return PAGE_SIZE;
> +       }
> +
>         /* we don't support blocksize < PAGE_SIZE quite yet. */
>         WARN_ON_ONCE(pos != page_offset(page));
>         WARN_ON_ONCE(plen != PAGE_SIZE);
> --
> 2.18.0
>

Thanks,
Andreas