linux-ext4 - Re: [PATCH v12 04/12] block: Make blk-integrity preclude hardware inline encryption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 May 2020 10:30:26 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Satya Tangirala <satyat@...gle.com>
Cc:     linux-block@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-fscrypt@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net, linux-ext4@...r.kernel.org,
        Barani Muthukumaran <bmuthuku@....qualcomm.com>,
        Kuohong Wang <kuohong.wang@...iatek.com>,
        Kim Boojin <boojin.kim@...sung.com>
Subject: Re: [PATCH v12 04/12] block: Make blk-integrity preclude hardware
 inline encryption

On Thu, Apr 30, 2020 at 11:59:51AM +0000, Satya Tangirala wrote:
> Whenever a device supports blk-integrity, make the kernel pretend that
> the device doesn't support inline encryption (essentially by setting the
> keyslot manager in the request queue to NULL).
> 
> There's no hardware currently that supports both integrity and inline
> encryption. However, it seems possible that there will be such hardware
> in the near future (like the NVMe key per I/O support that might support
> both inline encryption and PI).
> 
> But properly integrating both features is not trivial, and without
> real hardware that implements both, it is difficult to tell if it will
> be done correctly by the majority of hardware that support both.
> So it seems best not to support both features together right now, and
> to decide what to do at probe time.
> 
> Signed-off-by: Satya Tangirala <satyat@...gle.com>

Looks good, you can add:

    Reviewed-by: Eric Biggers <ebiggers@...gle.com>

- Eric