[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 4 Apr 2022 14:38:58 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Felix Kuehling <felix.kuehling@....com>
Cc: Christoph Hellwig <hch@....de>, Alex Sierra <alex.sierra@....com>,
david@...hat.com, linux-mm@...ck.org, rcampbell@...dia.com,
linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org,
amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
jglisse@...hat.com, apopple@...dia.com, willy@...radead.org,
akpm@...ux-foundation.org
Subject: Re: [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages
only
On Fri, Apr 01, 2022 at 04:08:35PM -0400, Felix Kuehling wrote:
> > In general I find the vm_normal_lru_page vs vm_normal_page
> > API highly confusing. An explicit check for zone device pages
> > in the dozen or so spots that care has a much better documentation
> > value, especially if accompanied by comments where it isn't entirely
> > obvious.
>
> OK. We can do that. It would solve the function naming problem, and we'd
> have more visibility of device page handling in more places in the kernel,
> which has educational value.
Personally I find the 'is page XYZ' pretty confusing, like I don't
know half of what the PageKsm annotations are for..
Testing against a specific property the code goes on to use right away
seems more descriptive to me.
Jason
Powered by blists - more mailing lists