linux-ext4 - Re: [e2fsprogs PATCH] libext2fs: fix 32-bit Windows build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Jan 2023 20:53:57 +0000
From:   Eric Biggers <ebiggers@...nel.org>
To:     "Darrick J. Wong" <djwong@...nel.org>
Cc:     linux-ext4@...r.kernel.org,
        Paulo Antonio Alvarez <pauloaalvarez@...il.com>
Subject: Re: [e2fsprogs PATCH] libext2fs: fix 32-bit Windows build

On Wed, Jan 04, 2023 at 08:05:09PM +0000, Eric Biggers wrote:
> On Wed, Jan 04, 2023 at 08:54:27AM -0800, Darrick J. Wong wrote:
> > On Wed, Jan 04, 2023 at 01:03:01AM -0800, Eric Biggers wrote:
> > > From: Eric Biggers <ebiggers@...gle.com>
> > > 
> > > _WIN32 is the standard macro to detect Windows, regardless of 32-bit or
> > > 64-bit.  _WIN64 is for 64-bit Windows only.  Use _WIN32 where _WIN64 was
> > > incorrectly being used.
> > > 
> > > This fixes several 32-bit Windows build errors, for example this one:
> > 
> > Color me impressed, I would have applied to deprecate Windows support
> > entirely, particularly given the existence of WSL.

Note that WSL doesn't really eliminate the need for native Windows binaries,
since WSL is something that has to be explicitly enabled and configured; see
https://learn.microsoft.com/en-us/windows/wsl/install.  It's not like running a
32-bit binary on a 64-bit system which is something that just works.  You can't
just take a Linux binary and run it on Windows.

- Eric