linux-ext4 - [PATCH] ext4: Put inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Apr 2023 21:34:20 +0800
From:   Wu Jianyue <wujianyue000@...il.com>
To:     tytso@....edu, adilger.kernel@...ger.ca
Cc:     linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wu Jianyue <wujianyue000@...il.com>
Subject: [PATCH] ext4: Put inode_operations in inode.c

inode_operations is more suitable to put in inode.c,
instead of file.c, so moved to inode.c.

Because struct inode_operations's functions are already
included in header file, so no need to change header files.

Signed-off-by: Wu Jianyue <wujianyue000@...il.com>
---
 fs/ext4/file.c  | 11 -----------
 fs/ext4/inode.c | 12 ++++++++++++
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 0b8b4499e5ca..a64184c74e4e 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -961,14 +961,3 @@ const struct file_operations ext4_file_operations = {
 	.fallocate	= ext4_fallocate,
 };
 
-const struct inode_operations ext4_file_inode_operations = {
-	.setattr	= ext4_setattr,
-	.getattr	= ext4_file_getattr,
-	.listxattr	= ext4_listxattr,
-	.get_inode_acl	= ext4_get_acl,
-	.set_acl	= ext4_set_acl,
-	.fiemap		= ext4_fiemap,
-	.fileattr_get	= ext4_fileattr_get,
-	.fileattr_set	= ext4_fileattr_set,
-};
-
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 8dbd352e3986..db08dd51b6b3 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -6147,3 +6147,15 @@ vm_fault_t ext4_page_mkwrite(struct vm_fault *vmf)
 	ext4_journal_stop(handle);
 	goto out;
 }
+
+const struct inode_operations ext4_file_inode_operations = {
+	.setattr	= ext4_setattr,
+	.getattr	= ext4_file_getattr,
+	.listxattr	= ext4_listxattr,
+	.get_inode_acl	= ext4_get_acl,
+	.set_acl	= ext4_set_acl,
+	.fiemap		= ext4_fiemap,
+	.fileattr_get	= ext4_fileattr_get,
+	.fileattr_set	= ext4_fileattr_set,
+};
+
-- 
2.34.1