[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 2 Feb 2024 21:15:29 +0800
From: Zorro Lang <zlang@...hat.com>
To: Eric Whitney <enwlinux@...il.com>
Cc: fstests@...r.kernel.org, linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH] generic/459: don't run on non-journaled ext4 file systems
On Wed, Jan 24, 2024 at 02:53:06PM -0500, Eric Whitney wrote:
> generic/459 fails when run on an ext4 file system created without a
> journal or when its journal has not been loaded at mount time.
>
> The test expects that a file system that it has been unable to freeze
> will be automatically remounted read only. However, the default error
> handling policy for ext4 is to continue when possible after errors.
>
> A workaround was added to the test in the past to force ext4 to
> perform a read only remount in order to meet the test's expectations.
> The touch command was used to create a new file after a freeze failure.
> This forces ext4 to start a new journal transaction, where it discovers
> the journal has previously aborted due to lack of space, and triggers
> special case error handling that results in a read only remount.
>
> The workaround requires a journal. Since ext4 is behaving as designed,
> prevent the test from running if there isn't one.
>
> Signed-off-by: Eric Whitney <enwlinux@...il.com>
> ---
> tests/generic/459 | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/generic/459 b/tests/generic/459
> index c3f0b2b0..63fbbc9b 100755
> --- a/tests/generic/459
> +++ b/tests/generic/459
> @@ -49,6 +49,11 @@ _require_command "$THIN_CHECK_PROG" thin_check
> _require_freeze
> _require_odirect
>
> +# non-journaled ext4 won't remount read only after freeze failure
> +if [ "$FSTYP" == "ext4" ]; then
> + _require_metadata_journaling
I'm wondering ... won't other fs need this, besides ext4?
> +fi
> +
> vgname=vg_$seq
> lvname=lv_$seq
> poolname=pool_$seq
> --
> 2.30.2
>
>
Powered by blists - more mailing lists