linux-hardening - Re: stable-rc: 6.1: gcc-plugins: Reorganize gimple includes for GCC 13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Aug 2023 13:31:16 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     linux-stable <stable@...r.kernel.org>,
        lkft-triage@...ts.linaro.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sasha Levin <sashal@...nel.org>,
        Anders Roxell <anders.roxell@...aro.org>,
        linux-hardening@...r.kernel.org,
        Palmer Dabbelt <palmer@...osinc.com>
Subject: Re: stable-rc: 6.1: gcc-plugins: Reorganize gimple includes for GCC
 13

On Tue, Aug 08, 2023 at 10:57:30AM +0530, Naresh Kamboju wrote:
> LKFT build plans updated with toolchain gcc-13 and here is the report.
> 
> Stable rc 6.1 arm64 builds with gcc-13 failed and the bisection is pointing
> to this as first bad commit,
> 
> # first fixed commit: [e6a71160cc145e18ab45195abf89884112e02dfb]
>    gcc-plugins: Reorganize gimple includes for GCC 13
> 
> Thanks Anders for bisecting this problem against Linux 6.2-rc6.
> 
> Build errors:
> ---------------
> In file included from /builds/linux/scripts/gcc-plugins/gcc-common.h:75,
>                  from /builds/linux/scripts/gcc-plugins/stackleak_plugin.c:30:
> /usr/lib/gcc-cross/aarch64-linux-gnu/13/plugin/include/gimple-fold.h:72:32:
> error: use of enum 'gsi_iterator_update' without previous declaration
>    72 |                           enum gsi_iterator_update,
>       |                                ^~~~~~~~~~~~~~~~~~
> 
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>

I'm slightly confused by this report. Is it the build of v6.1 that is
failing? Commit e6a71160cc14 ("gcc-plugins: Reorganize gimple includes
for GCC 13") was added in v6.2.

I think you're saying you need it backported to the v6.1 stable tree?
("First bad commit" is really the first good commit?)

-Kees

-- 
Kees Cook