linux-hardening - Re: [PATCH v4 1/8] mm/util: Introduce kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 11 Oct 2023 21:43:59 +0530
From: Kartik <kkartik@...dia.com>
To: <andy.shevchenko@...il.com>
CC: <akpm@...ux-foundation.org>, <andy@...nel.org>, <arnd@...db.de>,
	<frank.li@...o.com>, <jonathanh@...dia.com>, <keescook@...omium.org>,
	<kkartik@...dia.com>, <linux-hardening@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
	<linux-tegra@...r.kernel.org>, <pdeschrijver@...dia.com>,
	<petlozup@...dia.com>, <pshete@...dia.com>, <robh@...nel.org>,
	<stefank@...dia.com>, <thierry.reding@...il.com>, <ulf.hansson@...aro.org>
Subject: Re: [PATCH v4 1/8] mm/util: Introduce kmemdup_array() to duplicate an array

On Wed, 2023-10-11 at 18:36:11 +0300, Andy Shevchenko wrote:
> On Wed, Oct 11, 2023 at 2:17 PM Kartik <kkartik@...dia.com> wrote:
> >
> > Introduce function kmemdup_array(), that will copy `n` number of
> > elements from a given array `src` to `dst`.
> >
> > On success, kmemdup_array() returns 0 and copy the elements from `src`
> > to newly allocated array `dst`, it also stores number of elements
> > copied from `src` array to `dst_count` parameter. On failure, this
> > returns a negative integer value containing the error value.
> 
> Hmm... Why is it so complicated?
> 
> Can it be as simple as
> 
>   return kmemdup(size_mul());
> 
> ?
> 
> --
> With Best Regards,
> Andy Shevchenko

The idea was to validate the arguments that are passed to kmemdup_array().
But I agree doing so complicates things here.

I will update this in the next patchset.

Thanks & Regards,
Kartik