linux-hardening - Re: [PATCH v2] wifi: wl1251: replace deprecated strncpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 23 Oct 2023 17:28:23 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Justin Stitt <justinstitt@...gle.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org, Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v2] wifi: wl1251: replace deprecated strncpy with strscpy

Justin Stitt <justinstitt@...gle.com> wrote:

> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> 
> Based on other assignments of similar fw_version fields we can see that
> NUL-termination is required but not NUL-padding:
> ethernet/intel/ixgbe/ixgbe_ethtool.c
> 1111:   strscpy(drvinfo->fw_version, adapter->eeprom_id,
> 1112:           sizeof(drvinfo->fw_version));
> 
> ethernet/intel/igc/igc_ethtool.c
> 147:    scnprintf(adapter->fw_version,
> 148:              sizeof(adapter->fw_version),
> 153:    strscpy(drvinfo->fw_version, adapter->fw_version,
> 154:            sizeof(drvinfo->fw_version));
> 
> wireless/broadcom/brcm80211/brcmfmac/core.c
> 569:    strscpy(info->fw_version, drvr->fwver, sizeof(info->fw_version));
> 
> wireless/broadcom/brcm80211/brcmsmac/main.c
> 7867:           snprintf(wlc->wiphy->fw_version,
> 7868:                    sizeof(wlc->wiphy->fw_version), "%u.%u", rev, patch);
> 
> wireless/broadcom/b43legacy/main.c
> 1765:   snprintf(wiphy->fw_version, sizeof(wiphy->fw_version), "%u.%u",
> 
> wireless/broadcom/b43/main.c
> 2730:   snprintf(wiphy->fw_version, sizeof(wiphy->fw_version), "%u.%u",
> 
> wireless/intel/iwlwifi/dvm/main.c
> 1465:   snprintf(priv->hw->wiphy->fw_version,
> 1466:            sizeof(priv->hw->wiphy->fw_version),
> 
> wireless/intel/ipw2x00/ipw2100.c
> 5905:   snprintf(info->fw_version, sizeof(info->fw_version), "%s:%d:%s",
> 
> A suitable replacement is `strscpy` due to the fact that it guarantees
> NUL-termination on the destination buffer without unnecessarily
> NUL-padding.
> 
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@...r.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@...gle.com>
> Reviewed-by: Kees Cook <keescook@...omium.org>

Patch applied to wireless-next.git, thanks.

70bd8e0d01f6 wifi: wl1251: replace deprecated strncpy with strscpy

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20231018-strncpy-drivers-net-wireless-ti-wl1251-main-c-v2-1-67b63dfcb1b8@google.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches