linux-kernel - Re: [PATCH] Add SATA device to VIA IRQ quirk fixup list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Jul 2006 16:46:20 +0100
From:	Sergio Monteiro Basto <sergio@...giomb.no-ip.org>
To:	Andrew Morton <akpm@...l.org>
Cc:	Jeff Garzik <jeff@...zik.org>, greg@...ah.com, cw@...f.org,
	harmon@....edu, linux-kernel@...r.kernel.org,
	Daniel Drake <dsd@...too.org>
Subject: Re: [PATCH] Add SATA device to VIA IRQ quirk fixup list

On Fri, 2006-07-14 at 07:43 -0700, Andrew Morton wrote:
> On Fri, 14 Jul 2006 07:51:20 -0400
> Jeff Garzik <jeff@...zik.org> wrote:
> 
> > Daniel Drake wrote:
> > > Jeff Garzik wrote:
> > >> Daniel Drake wrote:
> > >>> Gentoo users at http://bugs.gentoo.org/138036 reported a 2.6.16.17 
> > >>> regression:
> > >>> new kernels will not boot their system from their VIA SATA hardware.
> > >>>
> > >>> The solution is just to add the SATA device to the fixup list.
> > >>> This should also fix the same problem reported by Scott J. Harmon on 
> > >>> LKML.
> > >>>
> > >>> Signed-off-by: Daniel Drake <dsd@...too.org>
> > >>
> > >> Same NAK comment as before...
> > > 
> > > I didn't see this patch posted anywhere before, but I just did some more 
> > > searching and found something similar. Are you referring to 
> > > http://lkml.org/lkml/2006/6/24/184 ?
> > 
> > Same rationale, but the VIA SATA PCI ID had been submitted before, as 
> > well...
> > 
> 
> argh.  Is someone able to confirm that 2.6.18-rc1-mm2 works OK?  In that
> kernel I did a desperation reversion of the offending patches
> (revert-VIA-quirk-fixup-additional-PCI-IDs.patch and
> revert-PCI-quirk-VIA-IRQ-fixup-should-only-run-for-VIA-southbridges.patch).
> 
> Guys, this is a really serious failure but afaict nobody is working on it
> and generally nothing at all is happening.
> 
> How do we fix all this?  (Who owns it?)

Andrew, 
please listen to me ,
I think 
DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq)
is wright if interrupts are in XT-PIC mode, If we disable APIC or/and
Local APIC, yes we have to quirk the VIA PCI interrupts, ok ?

if not, if we have IO-APIC enabled (with ACPI I guess, ACPI knows make
IRQ routings ), we don't need neither should quirks the VIA PCIs.
This is my opinion base on some emails from Alan Cox , Bjorn Helgas
etc.. and for now is the best shot we have.


Thanks,
---
Sérgio M. B.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/