lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Jul 2006 20:30:18 -0700 From: "Randy Dunlap" <rdunlap@...otime.net> To: Michael Krufky <mkrufky@...uxtv.org>, Linux and Kernel Video <video4linux-list@...hat.com>, Andrew Morton <akpm@...l.org>, Axel Thimm <Axel.Thimm@...pms.net>, linux-kernel <linux-kernel@...r.kernel.org>, Mauro Carvalho Chehab <mchehab@...radead.org>, Randy Dunlap <rdunlap@...otime.net> Subject: Re: bttv-driver.c:3964: error: void value not ignored as it ought to be > Michael Krufky wrote: > > Nish Aravamudan wrote: > >> On 7/17/06, Michael Krufky <mkrufky@...uxtv.org> wrote: > >>> Hmmm... This was caused by the "Check all __must_check warnings in > >>> bttv." patch from Randy Dunlap (cc's from original thread added) > >>> > >>> I am aware that this was done for various reasons of sanity checking, > >>> however, we cannot check the return value of a void ;-) > >> For the sanity checking, I don't think video_device_create_file() > >> should be a void function. It probably should return > >> class_device_create_file()'s return value, no? As it can fail... > >> > > > > You are correct... I was merely pointing out the error, but now I see it > > runs deeper than I had thought. I will fix both > > video_device_create_file and video_device_remove_file to return the > > class_device_foo return values, then I'll push it over to Mauro. > > I was in a rush when I wrote that, and I wasn't thinking. > video_device_remove_file stays as a void. > > Anyway, here is the fix. This is already in my tree ( > http://linuxtv.org/hg/~mkrufky/v4l-dvb ) but split into separate patches. Hi, Thanks for taking care of this. I'll look over it and see what I missed. Right now I have terrible wireless connections/problems. Sorry about the delay. --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists