lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Jul 2006 17:53:35 +0100 (IST) From: Dave Airlie <airlied@...ux.ie> To: Jeff Garzik <jeff@...zik.org> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH] drm: remove pci domain local copy (02/07) > I would presume that hose goes away too? Well not yet as I used it below... > >> +static inline int drm_get_pci_domain(struct drm_device *dev) >> +{ >> +#ifdef __alpha__ >> + return dev->hose->bus->number; >> +#else >> + return 0; >> +#endif >> +} > > Please use the always-present pci_domain_nr() rather than inventing a > DRM-specific function that does the same thing. Ah well I didn't know that existed, I merely was just moving some code in the DRM into another function in the DRM, it didn't occur that someone might have a generic function and not put it into the DRM code.. I'll look into it thanks, Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie Linux kernel - DRI, VAX / pam_smb / ILUG - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists