linux-kernel - Re: [PATCH 5/6] Begin abstraction of sensitive instructions: asm files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Jul 2006 13:25:47 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Peter Chubb <peter@...bb.wattle.id.au>
Cc:	Chuck Ebbert <76306.1226@...puserve.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, Andi Kleen <ak@....de>
Subject: Re: [PATCH 5/6] Begin abstraction of sensitive instructions:
	asm	files

On Wed, 2006-07-26 at 09:52 +1000, Peter Chubb wrote:
> >>>>> "Rusty" == Rusty Russell <rusty@...tcorp.com.au> writes:
> 
> Rusty> 	Agreed: certainly eax should be mentioned.  GET_CR0_INTO_EAX?
> Rusty> MOV is a bit close to describing how it's happening (which, on
> Rusty> paravirt it might not be) so it might lead the reader to
> Rusty> unwarranted assumptions.
> 
> Aren't these ideal cases to use a tool to convert, rather than adding
> manual changes to the source?  The `afterburner' approach works quite
> well for this kind of thing.

Agreed, afterburner works well in that it's minimally invasive in the
source.  However, that is precisely the opposite of the aim of patches
like this one which are integrated: that the source code be explicit.

Cheers,
Rusty.
-- 
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/