linux-kernel - Re: [PATCH] CCISS: Don't print driver version until we actually find a device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Jul 2006 00:41:16 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Arjan van de Ven <arjan@...radead.org>
CC:	Jesper Juhl <jesper.juhl@...il.com>,
	Bjorn Helgaas <bjorn.helgaas@...com>,
	Andrew Morton <akpm@...l.org>,
	Mike Miller <mike.miller@...com>, iss_storagedev@...com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] CCISS: Don't print driver version until we actually	find
 a device

Arjan van de Ven wrote:
> On Wed, 2006-07-26 at 00:43 +0200, Jesper Juhl wrote:
>> On 26/07/06, Bjorn Helgaas <bjorn.helgaas@...com> wrote:
>>> If we don't find any devices, we shouldn't print anything.
>>>
>> I disagree.
>> I find it quite nice to be able to see that the driver loaded even if
>> it finds nothing. At least then when there's a problem, I can quickly
>> see that at least it is not because I didn't forget to load the
>> driver, it's something else. Saves time since I can start looking for
>> reasons why the driver didn't find anything without first spending
>> additional time checking if I failed to cause it to load for some
>> reason.
> 
> I'll add a second reason: it is a REALLY nice property to be able to see
> which driver is started last in case of a crash/hang, so that the guilty
> party is more obvious..

OTOH, it is not a property that scales well at all.

When you build extra drivers into the kernel, or distros load drivers 
you don't need (_every_ distro does this), you wind up with a bunch of 
version strings for drivers for hardware you don't have.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/