linux-kernel - Re: [PATCH 1/3] scsi : megaraid_{mm,mbox}: 64-bit DMA capability checker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Jul 2006 13:20:54 -0500
From:	James Bottomley <James.Bottomley@...elEye.com>
To:	"Ju, Seokmann" <Seokmann.Ju@...l.com>
Cc:	vvs@...ru, akpm@...l.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Patro, Sumant" <Sumant.Patro@...enio.com>,
	"Yang, Bo" <Bo.Yang@...enio.com>
Subject: Re: [PATCH 1/3] scsi : megaraid_{mm,mbox}: 64-bit DMA capability
	checker

On Tue, 2006-07-25 at 08:44 -0600, Ju, Seokmann wrote:
> This patch contains 
> - a fix for 64-bit DMA capability check in megaraid_{mm,mbox} driver.
> - includes changes (going back to 32-bit DMA mask if 64-bit DMA mask
> failes) suggested by James with previous patch.
> - addition of SATA 150-4/6 as commented by Vasily Averin.

Warning: trailing whitespace in lines 885,889 of
drivers/scsi/megaraid/megaraid_mbox.c
Warning: trailing whitespace in lines
13,15,16,19,21,22,26,27,29,31,33,37,39,46 of
Documentation/scsi/ChangeLog.megaraid

I'll fix it up this time, but in future could you trailing whitespace
check your patches? (git will do this for you).

Also, when you do a git workflow, the body of the email becomes the
commit message, so things like this

> This is a third patch which follows prevous two patches ([PATCH 1/3]
> and
> [PATCH 2/3]).

while no doubt being useful to the members of linux-scsi who are
actually unable to count aren't actually useful in commit messages.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/