| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Jul 2006 23:26:43 +0200 From: Sam Ravnborg <sam@...nborg.org> To: Andi Kleen <ak@...e.de> Cc: Arjan van de Ven <arjan@...ux.intel.com>, linux-kernel@...r.kernel.org, akpm@...l.org Subject: Re: [patch 5/5] Add the -fstack-protector option to the CFLAGS On Fri, Jul 28, 2006 at 09:00:01PM +0200, Andi Kleen wrote: > On Friday 28 July 2006 20:48, Arjan van de Ven wrote: > > On Fri, 2006-07-28 at 20:45 +0200, Andi Kleen wrote: > > > > +ifdef CONFIG_CC_STACKPROTECTOR > > > > +CFLAGS += $(call cc-ifversion, -lt, 0402, -fno-stack-protector) > > > > +CFLAGS += $(call cc-ifversion, -ge, 0402, -fstack-protector) > > > > > > Why can't you just use the normal call cc-option for this? > > > > this requires gcc 4.2; cc-option is not useful for that. > > The CC option thing is also very ugly. The check is executed once pr. kernel compile - or at least once pr. line. The reson to use cc-ifversion is that we need to check for a specific gcc version and not just support for a specific argument type. That said - checking for a version is not as reliable as checking if a certain feature is really supported but Arjan suggested testing for version >= 4.2 should do it. Also we do not have any helpers in kbuild to do so -that could be worked out so we could do something almost as elegant as $(call cc-ifversion ...) Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists