linux-kernel - Re: [PATCH for 2.6.18] [8/8] MM: Remove rogue readahead printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 29 Jul 2006 17:14:28 -0400
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	Andi Kleen <ak@...e.de>
Cc:	torvalds@...l.org, discuss@...-64.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for 2.6.18] [8/8] MM: Remove rogue readahead printk

On Sat, 2006-07-29 at 21:42 +0200, Andi Kleen wrote:
> For some reason it triggers always with NFS root and spams the kernel
> logs of my nfs root boxes a lot.
> 
> Cc: trond.myklebust@....uio.no
> Signed-off-by: Andi Kleen <ak@...e.de>

Big ACK! I never really understood why we needed this printk, and yes,
it does spam the syslog heavily on all NFS clients...

Cheers,
  Trond

> ---
>  mm/filemap.c |    2 --
>  1 files changed, 2 deletions(-)
> 
> Index: linux-2.6.18-rc2-git7/mm/filemap.c
> ===================================================================
> --- linux-2.6.18-rc2-git7.orig/mm/filemap.c
> +++ linux-2.6.18-rc2-git7/mm/filemap.c
> @@ -849,8 +849,6 @@ static void shrink_readahead_size_eio(st
>  		return;
>  
>  	ra->ra_pages /= 4;
> -	printk(KERN_WARNING "Reducing readahead size to %luK\n",
> -			ra->ra_pages << (PAGE_CACHE_SHIFT - 10));
>  }
>  
>  /**

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/