linux-kernel - Re: [PATCH 2/2] headers_check: fix #include regexp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 29 Jul 2006 12:42:48 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Russell King <rmk+lkml@....linux.org.uk>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 2/2] headers_check: fix #include regexp

On Sat, Jul 29, 2006 at 09:25:11AM +0100, Russell King wrote:
> On Sat, Jul 29, 2006 at 12:22:49PM +0400, Alexey Dobriyan wrote:
> > Note it's [SPACE TAB]*
> 
> Why not use [[:space:]] rather than [ 	] ?  It's hard to see what black
> characters on a black background are actually trying to do.

Indeed. What about this? I assume nobody sane would use \n, \f or \v in
between ;-)

[PATCH] headers_check: fix #include regexp

Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
---

 scripts/hdrcheck.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/scripts/hdrcheck.sh
+++ b/scripts/hdrcheck.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-for FILE in `grep '^#include <' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
+for FILE in `grep '^[ \t]*#[ \t]*include[ \t]*<' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
     if [ ! -r $1/$FILE ]; then
 	echo $2 requires $FILE, which does not exist in exported headers
 	exit 1

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/