linux-kernel - Re: [PATCH 01/12] making the kernel -Wshadow clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 Jul 2006 11:41:48 -0400
From:	"Horst H. von Brand" <vonbrand@....utfsm.cl>
To:	"Jesper Juhl" <jesper.juhl@...il.com>
cc:	"Paul Jackson" <pj@....com>, linux-kernel@...r.kernel.org,
	akpm@...l.org
Subject: Re: [PATCH 01/12] making the kernel -Wshadow clean - fix mconf 

Jesper Juhl <jesper.juhl@...il.com> wrote:
> On 30/07/06, Paul Jackson <pj@....com> wrote:
> > Jesper wrote:
> > > -             cprint("%s", filename);
> > > +             cprint("%s", config_filename);
> >
> > Something seems strange here to me.  It looks like you are sometimes
> > resolving the shadowed symbols by making the more local symbol have the
> > longer name.

[...]

> >     instr
> 
> I don't recall using that variable name - I believe you mean 'intr'
> for interrupt that I used in place of 'irq'.

Please don't. If people are accustomed to irq, they will start wondering
what intr is all about (or what the difference is, etc).

> >     up

> I'd *love* to change this one - and down() as well - to up_sem() &
> down_sem().

Just too bad that there aren't semaphores anymore... and I can't find up()
down() in the headers anyway?

>             But, making that change would be a pretty major and
> somewhat disruptive api change, so I opted instead to change the local
> variable names. I plan to introduce a sepperate patch set later on
> that adds up_sem()/down_sem() wrappers around up()/down(), deprecate
> the old names and add an entry to feature-removal.txt - but doing it
> now as part of the -Wshadow cleanup would be too much pain.

Why not leave them alone for the time being then, and clean up in one sweep
later on?
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/