linux-kernel - Re: [PATCH] fix sun partition overflow over 1T

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 04 Aug 2006 17:56:30 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Eric Sandeen <esandeen@...hat.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix sun partition overflow over 1T

Ar Gwe, 2006-08-04 am 11:22 -0500, ysgrifennodd Eric Sandeen:
> Although sun partition labels aren't supposed to support > 1T, apparently
> linux partition editors will allow up to 2T.  This can cause problems
> in the kernel when these larger partitions are read, due to a signed
> int container.
> 
> num_sectors in the sun_disklabel struct is marked as __u32 in 2.4, and 
> as __be32 in 2.6.  However, this is assigned to a signed int in
> sun_partition():
> 
>                 int num_sectors;
> 
>                 st_sector = be32_to_cpu(p->start_cylinder) * spc;
>                 num_sectors = be32_to_cpu(p->num_sectors);
> 
> Changing num_sectors to an unsigned int avoids this problem.
> 

> Signed-off-by: Eric Sandeen <esandeen@...hat.com>

Acked-by: Alan Cox <alan@...hat.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/