linux-kernel - Re: [PATCH 1/10] hot-add-mem x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 5 Aug 2006 14:51:37 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Keith Mannthey <kmannth@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org, discuss@...-64.org,
	kmannth@...ibm.com, ak@...e.de, lhms-devel@...ts.sourceforge.net
Subject: Re: [PATCH 1/10] hot-add-mem x86_64: acpi motherboard fix

On Fri, 4 Aug 2006 07:13:51 -0600
Keith Mannthey <kmannth@...ibm.com> wrote:
> I have worked to integrate the feedback I recived on the last round of patches
> and welcome more ideas/advice. Thanks to everyone who has provied input on
> these patches already. 
> 
Just from review...

If new zone , which was empty at boot, are added into the system.
build_all_zonelists() has to be called. (see online_pages() in memory_hotplug.c)
it looks x86_64's __add_pages() doesn't calles it.

Precisely, look online_pages() (CCONFIG_MEMORY_HOTPLUG_SPARSE) 
==
       setup_per_zone_pages_min();

        if (need_zonelists_rebuild)
                build_all_zonelists();
        vm_total_pages = nr_free_pagecache_pages();
==
These 3 calls are necessary, I think.

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/