linux-kernel - Re: writing portable code based on BITS_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 06 Aug 2006 18:12:55 +0200
From:	Arjan van de Ven <arjan@...radead.org>
To:	"Om N." <xhandle@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: writing portable code based on BITS_PER_LONG?

On Sat, 2006-08-05 at 23:16 -0700, Om N. wrote:
> Hi,
> I am trying to port a driver written for IA32. This is a pci driver
> and has a chipset doing PCI <-> local bus data transfer, where local
> bus is 16 bit. So a number of values are converted by right/left
> shifting by 16 bits.
> 
> Now that I am doing porting, I would like to make it fully portable
> across AMD64 and IA32. What is the best method for this? Should I do
> something like,
> 
> #if  BITS_PER_LONG = 64
> shiftwidth = 48
> #else if BITS_PER_LONG = 32
> shiftwidth = 16
> #endif
> 
> I don't like this. I would not do it if there is some elegant way.

if you have a fixed sized bus, how about using the linux fixed size data
types? 

Also, maybe it would be a good idea to post the url to your code so that
people on this list can do a quick 64-bit safeness audit of your
driver... free work/help and all that ;-)

Greetings,
   Arjan van de Ven

-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/