linux-kernel - Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Aug 2006 16:35:23 +0300
From:	"Shem Multinymous" <multinymous@...il.com>
To:	"Muli Ben-Yehuda" <muli@...ibm.com>
Cc:	"Pavel Machek" <pavel@...e.cz>,
	"Björn Steinbrink" <B.Steinbrink@....de>,
	"Robert Love" <rlove@...ve.org>,
	"Jean Delvare" <khali@...ux-fr.org>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org, hdaps-devel@...ts.sourceforge.net
Subject: Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

Hi Muli,

On 8/8/06, Muli Ben-Yehuda <muli@...ibm.com> wrote:
> > > >   ret = thinkpad_ec_lock();
> > > >   if (ret)
> > > >           return ret;

> Ugh, I missed that - it's called _lock(), but it's actually
> down_interruptible().

Why is that confusing?

> Why not just get rid of the wrapper and call
> down_interruptible() directly? That makes it obvious what's going on.

We may end up needing to lock away other subsystems (ACPI?) that
touch the same ports. Apparently not an issue right now, but could
change with new firmware. (http://lkml.org/lkml/2006/8/7/147)

  Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/