linux-kernel - [RFC/PATCH] ACPI: Correctly recover from a failed S3 attempt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 8 Aug 2006 14:04:34 -0600
From:	"Jordan Crouse" <jordan.crouse@....com>
To:	linux-acpi@...r.kernel.org
cc:	linux-kernel@...r.kernel.org, william.morrow@....com
Subject: [RFC/PATCH] ACPI:  Correctly recover from a failed S3 attempt

We have a poorly behaving BIOS that simply returns from its suspend
procedure, rather then jumping to the restart routine indicated by
the FACS.  This appears to Linux as a failed S3 attempt.

This would normally succeed, but the sysenter msrs are not
restored and the restart fails.  It is not clear if this is the only
omission, but if the sysenter msrs are manually entered in the debugger, 
the OS resumes.

The attached patch would invoke the register restore function on failure.
This has absolutely no effect on correct systems, and, "does the right thing"
for failed or stupid BIOSes, at least as far as I am concerned.

Comments?
Jordan

-- 
Jordan Crouse
Senior Linux Engineer
Advanced Micro Devices, Inc.
<www.amd.com/embeddedprocessors>

View attachment "acpi-s3-fix.patch" of type "text/plain" (1138 bytes)