| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Aug 2006 15:35:07 +0200 From: Pavel Machek <pavel@....cz> To: "Rafael J. Wysocki" <rjw@...k.pl> Cc: LKML <linux-kernel@...r.kernel.org>, Linux PM <linux-pm@...l.org> Subject: Re: [RFC][PATCH -mm 1/5] swsusp: Introduce memory bitmaps Hi! > > > Introduce the memory bitmap data structure and make swsusp use in the suspend > > > phase. > ]--snip--[ > > > > Maybe that bitmap code should go to kernel/power/bitmaps.c or > > something? > > Then we'll also need another header or put the definitions in power.h, but > they will only be used by the code in snapshot.c anyway. Apart from this, > the "bitmap" functions refer to alloc_image_page() etc. that are internal > to snapshot.c. > > I thought it would be better to add this code to snapshot.c, because it's not > needed anywhere else and the separation of it would increase the overall > complexity for a little real gain. Okay, then. (I'd like to keep files at reasonable sizes, but...) > > but maybe it should go _after_ 4/5 and 5/5? Those are simple cleanups, this > > has break-something-potential and should rest in -mm for a while. > > OK, I'll redo the series this way. Thanks. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists