linux-kernel - Re: [-mm patch] CRYPTO_DEV_PADLOCK_AES must select CRYPTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Aug 2006 09:04:15 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, Michal Ludvig <michal@...ix.cz>
Subject: Re: [-mm patch] CRYPTO_DEV_PADLOCK_AES must select CRYPTO_BLKCIPHER

On Sun, Aug 20, 2006 at 06:09:28PM +0200, Adrian Bunk wrote:
> 
> BTW: The Kconfig+Makefile parts for padlock-sha seem to be missing.

Thanks Adrian.

> --- linux-2.6.18-rc4-mm2/drivers/crypto/Kconfig.old	2006-08-20 17:28:46.000000000 +0200
> +++ linux-2.6.18-rc4-mm2/drivers/crypto/Kconfig	2006-08-20 17:44:56.000000000 +0200
> @@ -16,6 +16,7 @@
>  config CRYPTO_DEV_PADLOCK_AES
>  	bool "Support for AES in VIA PadLock"
>  	depends on CRYPTO_DEV_PADLOCK
> +	select CRYPTO_BLKCIPHER
>  	default y
>  	help
>  	  Use VIA PadLock for AES algorithm.

Andrew, there is definitely something screwed up.  If you look at
my tree this patch is already in the top changeset that was
supposedly picked up by yout pull:

GIT aabffae140135096195f6fb04d165bb204517db2 git+ssh://master.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git

commit aabffae140135096195f6fb04d165bb204517db2
Author: Herbert Xu <herbert@...dor.apana.org.au>
Date:   Tue Aug 15 22:49:54 2006 +1000

    [CRYPTO] Kconfig: Added missing selects on BLKCIPHER
    
    Since padlock-aes and aes-s390/des-s390 now use the block cipher interface,
    they need to select the BLKCIPHER Kconfig option.
    
    Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Indeed, the s390 bits are there.  However, the padlock bits have
gong missing.  Perhaps there was a problem when it was merged with
the geode tree? This could explain why the Makefile bits for padlock
went missing too.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/