linux-kernel - Re: [PATCH] Signdness issue in drivers/video/intelfb/intelfbdrv.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 22 Aug 2006 10:15:20 +1000
From:	"Dave Airlie" <airlied@...il.com>
To:	"Eric Sesterhenn" <snakebyte@....de>
Cc:	linux-kernel@...r.kernel.org, "Andrew Morton" <akpm@...l.org>
Subject: Re: [PATCH] Signdness issue in drivers/video/intelfb/intelfbdrv.c

On 8/21/06, Eric Sesterhenn <snakebyte@....de> wrote:
> hi,
>
> another gcc 4.1 signess warning:
>
> drivers/video/intelfb/intelfbdrv.c:419: warning: comparison of unsigned expression < 0 is always false
>
> since dinfo->mtrr_reg is of the type u32, the error check dinfo->mtrr_reg < 0
> is useless. This patch introduces a helper variable, which catches possible
> negative error values returned by mtrr_add()
>
> Signed-off-by: Eric Sesterhenn <snakebyte@....de>
>

NAK.
I've applied a much simpler fix to use make mtrr_reg an int to my
intelfb tree....

Dave.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/