linux-kernel - Re: [PATCH 07/16] GFS2: Directory handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 05 Sep 2006 15:02:03 +0100
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	linux-kernel@...r.kernel.org,
	Russell Cattelan <cattelan@...hat.com>,
	David Teigland <teigland@...hat.com>, hch@...radead.org
Subject: Re: [PATCH 07/16] GFS2: Directory handling

On Tue, 2006-09-05 at 10:43 +0200, Ingo Molnar wrote:
> * Steven Whitehouse <swhiteho@...hat.com> wrote:
[some lines snipped]
> > > >+	if ((char *)cur + cur_rec_len >= bh_end) {
> > > >+		if ((char *)cur + cur_rec_len > bh_end) {
> > > >+			gfs2_consist_inode(dip);
> > > >+			return -EIO;
> > > >+		}
> > > >+		return -ENOENT;
> > > >+	}
> > > 
> > > if((char *)cur + cur_rec_len > bh_end) {
> > > 	gfs2_consist_inode(dip);
> > > 	return -EIO;
> > > } else if((char *)cur + cur_rec_len == bh_end)
> > > 	return -ENOENT;
> > > 
> > ok
> 
> this one is not OK! Firstly, Jan, and i mentioned this before, please 
> stop using 'if(', it is highly inconsistent and against basic taste. We 
> only use this construct for function calls (and macros), not for C 
> statements.

I did use use if "if (" form when I made this change rather than a
direct copy & paste from this. So it is ok I think,

Steve.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/