lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 08 Sep 2006 09:54:00 +0200 From: Peter Zijlstra <a.p.zijlstra@...llo.nl> To: Mel Gorman <mel@....ul.ie> Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/8] Split the free lists into kernel and user parts Hi Mel, Looking good, some small nits follow. On Thu, 2006-09-07 at 20:04 +0100, Mel Gorman wrote: > +#define for_each_rclmtype_order(type, order) \ > + for (order = 0; order < MAX_ORDER; order++) \ > + for (type = 0; type < RCLM_TYPES; type++) It seems odd to me that you have the for loops in reverse order of the arguments. > +static inline int get_pageblock_type(struct page *page) > +{ > + return (PageEasyRclm(page) != 0); > +} I find the naming a little odd, I would have suspected something like: get_page_blocktype() or thereabout since you're getting a page attribute. > +static inline int gfpflags_to_rclmtype(unsigned long gfp_flags) > +{ > + return ((gfp_flags & __GFP_EASYRCLM) != 0); > +} gfp_t argument? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists