linux-kernel - Re: [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 09 Sep 2006 21:12:25 +0200
From:	Michael De Backer <micdb@...net.be>
To:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer

Le samedi 09 septembre 2006 à 17:15 +0100, Alan Cox a écrit :
> Ar Sad, 2006-09-09 am 17:37 +0200, ysgrifennodd Michael De Backer:
> > -       else if (m5229_revision == 0xc7)
> > +       else if (m5229_revision == 0xc7 || 0xc8)
> 
> I don't think that is what you mean..
> 
> NAK
Indeed, let's try again (please forgive my dumbness). 

Configuration bits are not set properly for DMA on some chipset
revisions. It has already been corrected for M5229 (rev c7) but not for
M5229 (rev c8). This leads to the bug described at
http://bugzilla.kernel.org/show_bug.cgi?id=5786 (lost interrupt + ide
bus hangs).

Signed-off-by: Michael De Backer <micdb@...net.be>
---
The following patch is against the 2.6.18-rc6 or 2.6.18-rc6-mm1 kernel:

--- linux/drivers/ide/pci/alim15x3.c.orig       2006-09-09
16:07:07.000000000 +0200
+++ linux/drivers/ide/pci/alim15x3.c    2006-09-09 16:08:25.000000000
+0200
@@ -730,7 +730,7 @@ static unsigned int __devinit ata66_ali1

	if(m5229_revision <= 0x20)
		tmpbyte = (tmpbyte & (~0x02)) | 0x01;
-       else if (m5229_revision == 0xc7)
+       else if (m5229_revision == 0xc7 || m5229_revision == 0xc8)
		tmpbyte |= 0x03;
	else
		tmpbyte |= 0x01;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/