linux-kernel - Re: [PATCH V3] VIA IRQ quirk behaviour change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 09 Sep 2006 17:34:40 -0400
From:	Daniel Drake <dsd@...too.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	akpm@...l.org, torvalds@...l.org, sergio@...giomb.no-ip.org,
	jeff@...zik.org, greg@...ah.com, cw@...f.org, bjorn.helgaas@...com,
	linux-kernel@...r.kernel.org, harmon@....edu, len.brown@...el.com,
	vsu@...linux.ru, liste@...det.net
Subject: Re: [PATCH V3] VIA IRQ quirk behaviour change

Alan Cox wrote:
> If they are on the V-Bus then the IRQ number controls routing if they
> are on the PCI bus the IRQ line controls routing as normal.

OK, so per your last mail, most VIA devices start on the PCI bus and 
then later are migrated onto the V-bus.

Devices on the PCI bus need to be quirked (in some circumstances), as 
when they are on the PCI bus they use the IRQ line for routing, and the 
IRQ line is what the quirk actually modifies.

V-bus devices do not need the quirk because IRQ routing there is handled 
by IRQ number alone.

Is the above correct?

I did some searching and couldn't find anything out about the V-bus, I 
assume that is some VIA-specific thing.

That aside, it appears we were talking about different situations in the 
earlier email. We have 3 device classes:

- Internal PCI bus devices
- Internal V-bus devices
- External PCI card devices

I was talking about the corner case where we quirk an external-PCI-card 
device when it is plugged into a mainboard which happens to be based on 
a VIA chipset, whereas you were objecting to the fact that my patch 
quirks both internal-PCI-bus and internal-V-bus devices (but only one of 
those classes needs to be quirked). Is that correct?

Final question for now, are you saying that the current quirk in 
mainline only quirks devices which are in the internal-PCI-bus class? 
i.e. all of the following are *not* available in internal-V-bus form?

DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0,
DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_1,
DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_2, 
DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_3, 
DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686,
DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4,
DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5,

Thanks.
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/