linux-kernel - Re: [PATCH] vt: Rework the console spawning variables.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Sep 2006 18:29:42 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	Linux Containers <containers@...ts.osdl.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] vt: Rework the console spawning variables.

On 09/09, Eric W. Biederman wrote:
> 
> This patch does several things.
> - The variables used are moved into a structure and declared in vt_kern.h
> - A spinlock is added so we don't have SMP races updating the values.
> - Instead of raw pid_t value a struct_pid is used to guard against
>   pid wrap around issues, if the daemon to spawn a new console dies.

I am not arguing against this patch, but it's a pity we can't use 'struct pid'
lockless. What dou you think about this:

	void delayed_free_pid(struct rcu_head *rhp)
	{
		struct pid *pid = container_of(rhp, struct pid, rcu);
		kmem_cache_free(pid_cachep, pid);
	}

	void put_pid_rcu(struct pid *pid)
	{
		if (atomic_dec_and_test(&pid->count))
			// this can happen only if delayed_put_pid()
			// was already fired, we can re-use pid->rcu
			call_rcu(&pid->rcu, delayed_free_pid);
	}

Now,

	update_pid()
	{
		// still needs some locking
		put_pid_rcu(pid);
		pid = get_pid(...);
	}

	use_pid()
	{
		rcu_read_lock();
		do_something(pid);
		rcu_read_unock();
	}

Thoughts?

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/