lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: 14 Sep 2006 10:51:01 +0800 From: Zang Roy-r61911 <tie-fei.zang@...escale.com> To: Jeff Garzik <jgarzik@...ox.com> Cc: Roland Dreier <rdreier@...co.com>, Andrew Morton <akpm@...l.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [patch 3/3] Add tsi108 On Chip Ethernet device driver support On Tue, 2006-09-12 at 22:43, Jeff Garzik wrote: > Roland Dreier wrote: > > > +struct tsi108_prv_data { > > > + volatile u32 regs; /* Base of normal regs */ > > > + volatile u32 phyregs; /* Base of register bank used for PHY > access */ > > > > Why volatile? This looks really wrong here. > > Indeed. I will remove it. > > > > > + data->regs = (u32)ioremap(einfo->regs, 0x400); /*FIX ME */ > > > + data->phyregs = (u32)ioremap(einfo->phyregs, 0x400); /*FIX > ME */ > > > > What needs to be fixed here? And why are you casting the result of > > ioremap to u32? Shouldn't you keep the normal return value? > > Oh, that's very, very wrong. I will find method to avoid this :-). Roy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists