| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Sep 2006 22:36:53 +0100 From: Alasdair G Kergon <agk@...hat.com> To: Andrew Morton <akpm@...l.org> Cc: linux-kernel@...r.kernel.org, Ishai Rabinovitz <ishai@...lanox.co.il> Subject: [PATCH 01/25] dm: fix alloc_dev error path From: Ishai Rabinovitz <ishai@...lanox.co.il> While reading the code I found a bug in the error path in alloc_dev in dm.c When blk_alloc_queue fails there is no call to free_minor. This patch fixes the problem. Signed-off-by: Ishai Rabinovitz <ishai@...lanox.co.il> Signed-off-by: Alasdair G Kergon <agk@...hat.com> Index: linux-2.6.18-rc7/drivers/md/dm.c =================================================================== --- linux-2.6.18-rc7.orig/drivers/md/dm.c 2006-09-14 20:11:38.000000000 +0100 +++ linux-2.6.18-rc7/drivers/md/dm.c 2006-09-14 20:19:42.000000000 +0100 @@ -943,7 +943,7 @@ static struct mapped_device *alloc_dev(i md->queue = blk_alloc_queue(GFP_KERNEL); if (!md->queue) - goto bad1; + goto bad1_free_minor; md->queue->queuedata = md; md->queue->backing_dev_info.congested_fn = dm_any_congested; @@ -993,6 +993,7 @@ static struct mapped_device *alloc_dev(i mempool_destroy(md->io_pool); bad2: blk_cleanup_queue(md->queue); + bad1_free_minor: free_minor(minor); bad1: module_put(THIS_MODULE); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists